private post can be sticky via quickedit

[maxemil]

While preparing translations to 3.4 I came across

​http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-xmlrpc-server.php#L908

This indicates that a private post cannot be marked as sticky.

• however it is quite possible to mark a private post as sticky while using quickedit.

Solution proposal, remove sticky tickbox on quickedit if post is private.
Or if this is only related to the XMLRPC, fix the returnmessage to a warning "a private post will only be visible to you, so sticky might not make any sense".

I'm thinking.. "either its possible or its not, the logic should be the same"

[markoheijnen]

yes, the logic should be the same. Added dev-feedback to define that the right way is for handling sticky posts.

Wonder if private isn't allowed we should add the check into stick_post().

[chriscct7]

This is a bug because mw_newPost's logic in that file allows a sticky post to be a private post whereas mw_editPost and _insert_post do not

[chriscct7]

Apparently postdata doesn't contain sticky. content_struct does. Patch 2 fixes this.

[obenland]

If we add it inside the if ( $post_type == 'post' && isset( $content_struct['sticky'] ) ) { check, we can remove the sticky check.

[wonderboymusic]

20662.diff​ refreshes this.

[obenland]

@wonderboymusic, there is a similar check further up in the file, doing an edit_others_posts cap verification. Should we do that here too? Might be worth making both checks work the same, what do you think?

[wonderboymusic]

20662.2.diff​ adds a helper that can be used in all 3 places where a post can be stuck

[obenland]

Looks good. Not sure how to test it but it looks good.

[obenland]

20662.3.diff​ fixes the bug for quick edit.

@wonderboymusic, your patch should go in as well, do you know of a good way for me to test it?

[wonderboymusic]

In 33325:

Ensure that private posts cannot be made sticky via Quick Edit.
DRY the logic for stickies in wp_xmlrpc_server by introducing ->_toggle_sticky().

Props wonderboymusic, obenland, chriscct7.
Fixes #20662.

[DrewAPicture]

The DocBlock for _toggle_sticky() is incomplete. At the very least, we need a summary describing what purpose the function serves. Adding description for why it's private is also a good idea.

[wonderboymusic]

In 33343:

After [33325], add a doc summary.

Fixes #20662.

[ocean90]

How could this land without any unit tests?

wp_xmlrpc_server::mw_editPost() fails making a post sticky becaue of the missing post_type, see 20662.4.diff​.

[obenland]

@wonderboymusic, can you take a look when you get a chance?

[wonderboymusic]

In 33612:

After [33325], supply a missing post_type in ->mw_editPost().

Add unit test.

Props ocean90.
Fixes #20662.

[ocean90]

In 34135:

XMLRPC: Don't allow private posts to be sticky.

See #20662.

[ocean90]

In 34151:

XMLRPC: Don't allow private posts to be sticky.

Merge of [34135] to the 4.3 branch.

See #20662.

[ocean90]

In 34152:

XMLRPC: Don't allow private posts to be sticky.

Merge of [33325], [33612], and [34135] to the 4.2 branch.

See #20662.

[ocean90]

In 34153:

XMLRPC: Don't allow private posts to be sticky.

Merge of [33325], [33612], and [34135] to the 4.1 branch.

See #20662.

[ocean90]

In 34154:

XMLRPC: Don't allow private posts to be sticky.

Merge of [33325], [33612], and [34135] to the 4.0 branch.

See #20662.

[ocean90]

In 34155:

XMLRPC: Don't allow private posts to be sticky.

Merge of [33325], [33612], and [34135] to the 3.9 branch.

See #20662.

[ocean90]

In 34156:

XMLRPC: Don't allow private posts to be sticky.

Merge of [33325], [33612], and [34135] to the 3.8 branch.

See #20662.

[ocean90]

In 34157:

XMLRPC: Don't allow private posts to be sticky.

Merge of [33325], [33612], and [34135] to the 3.7 branch.

See #20662.