WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#20671 closed defect (bug) (fixed)

Missing info for filesystem credential check on bulk deletion of themes in Multisite

Reported by: kobenland Owned by: dd32
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.3.2
Component: Network Admin Keywords: has-patch commit
Focuses: multisite Cc:

Description

Context: Bulk deleting Themes in Network Admin.

When checking for filesystem credentials in delete_theme(), the redirect url is missing information about the files to delete, since it is passed through POST and not GET.

I experienced it in 3.3.2 and it still occurs in the latest nightly build.

Attachments (3)

20671.diff (738 bytes) - added by kobenland 9 years ago.
Not sure if passing of the entire $_POST variable is a good idea, but we need 'action', 'checked' and the nonce (at least)
20671.2.diff (911 bytes) - added by kobenland 9 years ago.
Alternativ with only the required parameters and a more static base url
20671.3.diff (1.1 KB) - added by kobenland 9 years ago.
Added refactoring of redirect url

Download all attachments as: .zip

Change History (8)

@kobenland
9 years ago

Not sure if passing of the entire $_POST variable is a good idea, but we need 'action', 'checked' and the nonce (at least)

#1 @kobenland
9 years ago

  • Keywords has-patch added

@kobenland
9 years ago

Alternativ with only the required parameters and a more static base url

@kobenland
9 years ago

Added refactoring of redirect url

#2 @nacin
9 years ago

  • Owner set to dd32
  • Status changed from new to assigned

#3 @ryan
9 years ago

  • Milestone changed from Awaiting Review to 3.5

#4 @dd32
9 years ago

  • Keywords commit added; dev-feedback removed

Patch looks good, and tests out OK for me on Multisite.

#5 @dd32
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [22084]:

Fix Bulk Theme Deletion in the Network Admin when using FTP. Props kobenland. Fixes #20671

Note: See TracTickets for help on using tickets.