Function split() is deprecated

[gregrobson]

Encountered the following email error from a plugin.

Bei Fen has encountered an error: 8192, Function split() is deprecated, /wp-includes/rss.php, 104

I have checked rss.php, on line 104.

list($ns, $el) = split( ':', $element, 2);[[BR]]

change to

list($ns, $el) = explode( ':', $element, 2);[[BR]]

split() is now deprecated in PHP 5.3

[duck_]

wp-includes/rss.php is an external library that has been deprecated in WordPress (use SimplePie instead) so it will not be changed.

See #16325.

[gregrobson]

Okay, I'll contact the writer of the Bei Fen plugin - I had 80+ emails in the space of a minute due to it's reliance on this file. This is only from one installation of WordPress!

Didn't realise the deprecated files would not be updated. This is the first time I've ever filed a suspected bug!

[SergeyBiryukov]

#27382 was marked as a duplicate.

[SergeyBiryukov]

#28760 was marked as a duplicate.

[ocean90]

#36307 was marked as a duplicate.

[ocean90]

Although these are external libraries it's in our responsibility to make sure that it doesn't break an install. Since split() was completely removed in PHP7 we should go with https://core.trac.wordpress.org/attachment/ticket/36307/36307.v2.patch.
It would also allow hosts to more easily upgrade to PHP7.

[ocean90]

In 37402:

External Libraries: Replace split() with explode() in the deprecated Atom and MagpieRSS files.

Before PHP7 split() was throwing a deprecated notice, in PHP7 the function is completely removed and throws a fatal error.

Props achbed.
Fixes #20673.

[josephscott]

@ocean90 there are two other calls to split() that weren't fixed in this:

• https://core.trac.wordpress.org/browser/trunk/src/wp-includes/atomlib.php?rev=37402#L162
• https://core.trac.wordpress.org/browser/trunk/src/wp-includes/atomlib.php?rev=37402#L241

[ocean90]

@josephscott Thanks, do you want to prepare a patch?

[josephscott]

Done. I'm just replacing it with explode().

[SergeyBiryukov]

In 37461:

External Libraries: After [37402], replace two more instances of split() with explode() in wp-includes/atomlib.php.

Props josephscott.
Fixes #20673.

[pento]

#37194 was marked as a duplicate.