WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20695 closed defect (bug) (fixed)

Use the right hook for the theme information tab

Reported by: ocean90 Owned by: koopersmith
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Appearance Keywords: has-patch
Focuses: Cc:

Description

Otherwise the output will be before the <html> stuff, see http://cl.ly/GgOH

Attachments (2)

20695.patch (460 bytes) - added by ocean90 2 years ago.
20695.2.patch (1.1 KB) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (6)

ocean902 years ago

comment:2 ocean902 years ago

If we use iframe_header and iframe_footer we can retain the current filter. It will also prevent the output of unnecessary HTML like the admin menu. Makes it a easier for #20696.

Last edited 2 years ago by ocean90 (previous) (diff)

ocean902 years ago

comment:3 koopersmith2 years ago

Smart patch.

comment:4 koopersmith2 years ago

  • Owner set to koopersmith
  • Resolution set to fixed
  • Status changed from new to closed

In [20812]:

Theme Installer: Prevent unnecessary admin code from printing and print markup in correct order. Remove dead code. props ocean90, fixes #20695.

Note: See TracTickets for help on using tickets.