XML-RPC metaWeblog calls save posts with 'standard' post format

[koke]

As seen here ​http://ios.trac.wordpress.org/ticket/1069#comment:1

Steps to replicate:

1. Create a standard post using the regular web interface.
2. Edit and save the post using the iOS app.
3. Go back to web interface and you'll see an extra standard button.

Screenshot: ​http://img.thethemefoundry.com/two-standard-formats.png

The new wp.* methods do this right by using set_post_format() instead of calling wp_set_post_terms() directly

[koke]

Sorry for the duplicate patch. It's the same file, but accidentally double-clicked on the upload button

[duck_]

[16484] for #15405. Patch looks good.

[andyadams]

Has this made it into 3.4? I'm not familiar with Trac and the whole process, so forgive me if that's a dumb question.

I ask because this seems like a critical bug - creating a completely different post format is relatively major IMO.

[nacin]

We might need an upgrade routine to knock out post-format-standard terms from the DB.

[nacin]

In [21145]:

Use set_post_format(), not wp_set_post_terms(), in XML-RPC mw_newPost and mw_editPost. props koke. see #20697.

[nacin]

Also, formats should be set prior to wp_insert_post(), that way on publish, a plugin knows what format the post is. The new wp method handls this, but mw does not look like it does.

[markoheijnen]

mw_newPost does it correct but mw_editPost doesn't. There is still a lot of things happening after wp_update_post in mw_editPost.
Wonder if that should be fixed or not.

[nacin]

Two things:

• At the very least let's make sure that post formats are applied prior to publish in all XML-RPC methods.

• Upgrade routine to knock out post-format-standard terms from the DB.

[nacin]

In 22422:

Remove the post-format-standard term on upgrade if it exists in the database. fixes #20697.