some page gives 404 after reordering

[dissurion]

I've reordened a lot of nested test pages (most is 5 levels deep) and now I get a 404 on some of them. I can't lay my finger on a pattern though. When I reorder them again other pages have the 404 and not any more the reordered page. It al started when reordering a page with some childeren.

[dissurion]

Think I've found the pattern: it gives a 404 for every page whose id is higher than it's parent when that parent has a smaller id than it's parent.

my setup for a page:

18 p
3 — b
4 — c
14 — — t
5 — te
10 — — ar
7 — — — in
8 — — — — so
11 — — — som
13 — — — — qs
12 — — — qsfd

the following pages give a 404: t, ar, so

[dissurion]

18 p 
3 — b 
4 — c 
14 — — t 
5 — te 
10 — — ar 
7 — — — in 
8 — — — — so 
11 — — — som 
13 — — — — qs 
12 — — — qsfd

[davidhouse]

This seems kinda weird. Could you create more test pages to check this rigidly?

[dissurion]

It's actually easy to reproduce:

create 3 pages all with no parent:

1 test1
2 test2
3 test3

next make test2 a subpage of test1

1 test1
2 - test2
3 test3

and now make test1 a subpage of test3

3 test3
1 - test1
2 --test2

The page id of test2 is higher than that of test1, but that of test one is lower than it's parent, test3.
Result: 404 for test2.

The pattern may be more complex if other cases are found, but so far those are the only times where I've got a 404.

[dissurion]

fuck it, edit:

It's actually easy to reproduce:

create 3 pages all with no parent:

1 test1
2 test2
3 test3

next make test2 a subpage of test1

1 test1
2 - test2
3 test3

and now make test1 a subpage of test3

3 test3
1 - test1
2 --test2

The page id of test2 is higher than that of test1, but that of test one is lower than it's parent, test3. Result: 404 for test2.

The pattern may be more complex if other cases are found, but so far those are the only times where I've got a 404.

[davidhouse]

Confirm. Only works when fancy permalinks are turned on. I'll look into it.

[davidhouse]

Sorry, the bug only happens when fancy permalinks are turned on. That was ambiguous.

[davidhouse]

Tracked it down. The problem is in the rewrite rules: the rules for test3/test1/([^{/]+) for attachments appears before the rules for test3/test1/test2, so we get redirected and WP thinks we're looking for an attachment, name 'test2' on the page test3/test1. Working on a patch.}

[davidhouse]

Give this patch a try.

[ryan]

(In [3356]) Fix page permalink 404 when pages are reordered. Props David House. fixes #2071

[(none)]

Milestone 2.0 deleted