wp.getPosts xmlrpc using "number" when it should be using "numberposts"

[djcp]

See $SUBJECT. Using "number" to limit the number of posts returned is incorrect, as wp_get_recent_posts() expects this parameter to be called "numberposts".

A patch is attached to fix the parameter name to be "numberposts" - though we could have the API externally expose "number" yet give the parameter "numberposts" to wp_get_recent_posts().

[djcp]

To clarify, this means setting the number of posts that wp.getPosts returns is busted.

[SergeyBiryukov]

Also corrects PHPDocs

[SergeyBiryukov]

Related: #18433

The change happened in ticket:18433:wp.getPosts.6.patch​, the earlier patches used numberposts.

[ryan]

numberposts is ancient cruft. I'd rather not bubble it up. How about exposing number in wp.getPosts and passing it along as numberposts per the alternative suggested in the description.

[djcp]

Done and attached. No changes necessary to the phpdocs (but thanks for that before, Sergey) as the external API provided by wp.getPosts is the same.

[ryan]

We need some wp_getPosts unit tests.

[ryan]

In [20846]:

Fix post limiting in wp_getPosts(). Props djcp. fixes #20723