Context Navigation

← Previous Ticket
Next Ticket →

#20734 closed defect (bug) (fixed)

Registered Background image does not display in preview.

Reported by:	mfields	Owned by:	nacin
Priority:	normal	Milestone:	3.4
Component:	Customize	Version:	3.4
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description

I'm using code similar to the following to register custom background support on the latest version of trunk with a clean database:

function mytheme_register_custom_background_support() {
	add_theme_support( 'custom-background', array(
		'default-color' => 'f6f4f2',
		'default-image' => get_template_directory_uri() . '/images/background.png',
	) );
}
add_action( 'after_setup_theme', 'mytheme_register_custom_background_support' );

When I navigate to Appearance -> Background, I only see the background color in the "Preview" box. I would assume that the image should be shown here as well if a url is supplied as default-image in the add_theme_support() call.

I'll uploaded a patch which works for me, but may not be the best solution.

Attachments (1)

20734.diff (1.6 KB ) - added by mfields 14 years ago.

Download all attachments as: .zip

Change History (7)

@mfields
14 years ago

Attachment 20734.diff added

#1 @nacin
14 years ago

Keywords commit added; dev-feedback removed
Milestone Awaiting Review → 3.4

Does color work?

#2 @mfields
14 years ago

Color appears to work fine upon theme activation - displaying the default-color automatically. However, after a custom color was selected and then the "clear" link is clicked, the preview shows a white background. I think that it might be best to revert to the value of default-color is specified. What do you think?

Last edited 14 years ago by mfields (previous) (diff)

#3 @ryan
14 years ago

Related: #18041

#4 @nacin
14 years ago

I think that it might be best to revert to the value of default-color is specified. What do you think?

That would certainly make sense, yes. I recalled running into that, which is why I asked.

#5 @nacin
14 years ago

Owner set to nacin
Resolution → fixed
Status new → closed

In [20901]:

Preview by default the registered default image for custom backgrounds. props mfields, billerickson.

If there is a default color registered, show a 'Default' action rather than a 'Clear' action, as clearing the value would simply return to the default.

Make current_theme_supports() accept a second argument for 'custom-background' requests, the same as get_theme_support(). Missed in earlier changes, see #20249.

fixes #20734, fixes #18041.

#36 @nacin
14 years ago

In [21004]:

Custom background color: Show the 'Default' link when the input is empty and there is a default color registered. fixes #20448. see #20734.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#20734 closed defect (bug) (fixed)

Registered Background image does not display in preview.

Description

Attachments (1)

Change History (7)

@mfields 14 years ago

#1 @nacin 14 years ago

#2 @mfields 14 years ago

#3 @ryan 14 years ago

#4 @nacin 14 years ago

#5 @nacin 14 years ago

#36 @nacin 14 years ago