WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 23 months ago

#20737 closed enhancement (fixed)

Improve appearance of "choose from library" link for headers and backgrounds

Reported by: sabreuse Owned by:
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: UI Keywords: has-patch
Focuses: Cc:

Description

As seen <a href="http://wordpress.com/wp-admin/images/screenshots/flex-header-media-library.png">here</a>, the link we added to choose headers and backgrounds from the media library looks bad. This puts "or choose from image library" inline so it all flows better.

Attachments (7)

20737.diff (1.8 KB) - added by sabreuse 2 years ago.
20737.2.diff (1.8 KB) - added by sabreuse 2 years ago.
20737.3.diff (1.9 KB) - added by SergeyBiryukov 2 years ago.
20737.after.png (8.9 KB) - added by SergeyBiryukov 2 years ago.
20737.4.diff (1.7 KB) - added by ryan 23 months ago.
Two sections. PoC for custom header.
a-tale-of-two-sources.png (18.1 KB) - added by ryan 23 months ago.
20737.4.2.diff (3.7 KB) - added by SergeyBiryukov 23 months ago.

Download all attachments as: .zip

Change History (20)

sabreuse2 years ago

comment:1 SergeyBiryukov2 years ago

  • Component changed from General to UI
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.4

comment:2 SergeyBiryukov2 years ago

There's an odd space in the <a> tag in the first part of the patch: < a id="...">.

sabreuse2 years ago

comment:3 sabreuse2 years ago

Thanks for catching that - fixed in in 20737.2

SergeyBiryukov2 years ago

comment:4 SergeyBiryukov2 years ago

Perhaps we should also escape $image_library_url (done in 20737.3.diff).

In media_buttons(), get_upload_iframe_src() is escaped:
http://core.trac.wordpress.org/browser/tags/3.3.2/wp-admin/includes/media.php#L376

comment:5 jane2 years ago

I can't see what the new patch makes it look like (not on a computer with svn etc right now), but one concern I'd have is that if it's inline the width would be an issue on smaller screens/devices. It's pretty late in the game to change layout stuff with no testing since we're hopefully doing rc1 today.

SergeyBiryukov2 years ago

comment:6 SergeyBiryukov2 years ago

Here's what it looks like with the patch: 20737.after.png.

comment:7 jane2 years ago

"or" on its own line is how we have it in the uploader. Inline is how we do it for internal links. Thinking leave for now, standardize all the "or"s in 3.5 instead.

comment:8 jane2 years ago

  • Milestone changed from 3.4 to Future Release
  • Type changed from defect (bug) to enhancement

comment:9 nacin2 years ago

  • Milestone changed from Future Release to 3.4

It is on its own line in the uploader only because it is a larger font and a better visual. Here, it is simply super ugly. This was reported by sabreuse at the request of ryan and me.

More importantly, though, this string is improperly internationalized. (The uploader isn't much better.) We should make a change here regardless.

ryan23 months ago

Two sections. PoC for custom header.

ryan23 months ago

SergeyBiryukov23 months ago

comment:10 SergeyBiryukov23 months ago

20737.4.2.diff is an attempt to use a consistent formatting in both custom-background.php and custom-header.php while keeping the same appearance as on a-tale-of-two-sources.png.

comment:11 ryan23 months ago

In [20884]:

Improve appearance of "choose from library" link for headers and backgrounds. Props SergeyBiryukov, sabreuse. see #20737

comment:12 nacin23 months ago

In [20885]:

Move from 'Upload Image' to 'Select Image' as this section now includes choosing an image from the media library. see #20737.

comment:13 ryan23 months ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.