Make WordPress Core

Opened 14 years ago

Closed 11 years ago

#20745 closed defect (bug) (worksforme)

Hard-code less capability types

Reported by: Viper007Bond Owned by:
Priority: normal Milestone:
Component: Role/Capability Version: 3.0
Severity: normal Keywords: has-patch close
Cc: Focuses:

Description

We still hard-code some capability types thoughout the admin area.

For example edit_post is hard-coded as the edit attachment capability in the edit attachment pages. It should be pulled from the post type object instead so that it can be modified.

I've patched the ones I found.

Attachments (1)

20745.patch​ (6.8 KB ) - added by Viper007Bond 14 years ago.

Download all attachments as: .zip

Change History (7)

@Viper007Bond
14 years ago

#1 @scribu
14 years ago

'edit_post' is a meta capability. In other words, the conversion you made in your patch is already done in map_meta_cap(). Same for 'delete_post' etc.

Last edited 14 years ago by scribu (previous) (diff)

#2 @nacin
14 years ago

Had we done meta capabilities with the rest of custom post types in 3.0, I don't think edit_post, read_post, or delete_post would have made it into the $cap object.

#3 @nacin
14 years ago

  • Version 3.4 → 3.0

#4 @chriscct7
11 years ago

  • Keywords close added

Because of meta caps I'm not sure if there's anything here to solve

#5 @wonderboymusic
11 years ago

@Viper007Bond - what is your current state of mind here?

#6 @Viper007Bond
11 years ago

  • Milestone Awaiting Review
  • Resolution → worksforme
  • Status new → closed

I can't remember what I was originally on about. I likely didn't understand meta caps and I'm not sure I still fully do, but that's okay. Going to close.

Note: See TracTickets for help on using tickets.