The list "Display name publicly as" resets when cliking on the "Nickname" label

[paul.payen]

In the Screen "Edit Profile".

When you click on the "Nickname" the "Display name publicly as" list resets automaticaly with the username value.

Is this behaviour will be corrected in 3.4 ?

[paul.payen]

Defect Screen

[nacin]

I cannot reproduce this in either 3.3 or 3.4. Sounds like a plugin JavaScript conflict.

[SergeyBiryukov]

I couldn't reproduce either at first, but then I noticed something strange in Firefox:

1. Click on the "First Name", "Last Name" or "Nickname" label or input.
2. Click "Display name publicly as" dropdown.
3. It gets reset to the Nickname value (or Username, if Nickname is blank).

Not sure if that's the described issue, but sounds similar.

Tested in Firefox 12, Chrome 19, IE 8, Opera 11.64. Only happens in Firefox.

[paul.payen]

Yes Sergey. This is the issue I described. The dorpdown list gets reset when you click(or doubleclick) on labels.

I reproduce in IE8, IE9, Chrome19, Firefox 12.

Thank you for your reply.
My client is very important and is waiting for an answer from us.
Do you think a homemade patch is possible ?

[paul.payen]

This is the initial dropdown list.

[paul.payen]

This is the final list

[azaozz]

Replying to paul.payen:

Looking at the screenshot:

Where does the "vide" option in the select come from? That <select> contains the following options:

• username
• first name
• last name
• first + last
• last + first
• nickname

As all fields except "username" are empty, the select should have only that option.

If "vide" it taken from somewhere else, perhaps it should be set as "nickname", then the JS reset would work properly.

[nacin]

If "vide" is the current display name set from a nickname, and then the nickname is cleared, it is still a valid display name. The display name field is a dropdown only for convenience purposes; it is not limited to those combinations.

SergeyBiryukov reproduced this, so removing reporter-feedback. It's clearly a JS issue.

[azaozz]

Replying to nacin:

If "vide" is the current display name set from a nickname, and then the nickname is cleared, it is still a valid display name.

Right, that makes this an UX issue. Do we keep the old (non-existent) nickname as a display name, or do we remove it when the nickname is removed?

The display name field is a dropdown only for convenience purposes; it is not limited to those combinations.

It is a convenience method to select one value from the four fields above plus two combined values. If it can contain something else, there's no point of having a drop-down. It should be a normal text field so the user is not limited to what can be entered there, generally turning it into a 5th name filed.

[nacin]

Right, that makes this an UX issue. Do we keep the old (non-existent) nickname as a display name

Yes, absolutely.

It is a convenience method to select one value from the four fields above plus two combined values. If it can contain something else, there's no point of having a drop-down.

I disagree. There's nothing wrong with showing a list of defaults but if the default changes, we still keep the old value.

[azaozz]

Replying to nacin:

There's nothing wrong with showing a list of defaults but if the default changes, we still keep the old value.

Sounds good. But then why do we limit the user to only these display names? Seems the UI would need to be fixed there to allow the users to enter arbitrary display names (too late for 3.4, 3.5-early perhaps).

[azaozz]

Going to try a quick fix so the JS keeps all previous values for now.

[azaozz]

20747.patch keeps all previously entered values in the "Display name publicly as" drop-down and doesn't reset when a name field is emptied.

[azaozz]

Actually we don't need to keep reference to the previously selected value as we only append new <option> tags to the select and don't need the HTML IDs.

[paul.payen]

Thanks a lot for the quick fix.
We will test your patch on our WordPress instance.
I will let you know asap.

[SergeyBiryukov]

Replying to azaozz:

20747.patch keeps all previously entered values in the "Display name publicly as" drop-down and doesn't reset when a name field is emptied.

This also fixes the Firefox-only issue from comment:2.

[markjaquith]

Tested. Fixes the bug. Good for commit.

[nacin]

Good here too.

[azaozz]

In [20964]:

Do not clear the old values in "Display name publicly as" drop-down on the user profile screen, append new values there when the user changes any of20747 the name fields, fixes #20747