#20754 closed defect (bug) (fixed)
Minor RTL CSS fixes for 3.4
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.4 | Priority: | normal |
Severity: | normal | Version: | 3.4 |
Component: | RTL | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Just going through and patching inconsistencies between the stock styles and the RTL styles.
Attachments (2)
Change History (13)
#2
@
13 years ago
Tahoma seems to be the best font for RTL. Some previous tickets on that topic can be found in ticket:19424:11.
#3
@
13 years ago
Indeed, RTL should be Tahoma. I guess we can remove the bogus font-style, but we should blame it to figure out where and why it was added.
#4
@
13 years ago
Blame's got it tracked back to Azaozz @ http://core.trac.wordpress.org/changeset/17941 -- but that's likely just a overhaul of previous css, and I'm not sure how to trace it back further.
#6
in reply to:
↑ 5
@
13 years ago
Replying to SergeyBiryukov:
Added by yoavf in ticket:17324:3.2-rtl.diff.
Probably because the original style has italic, and that doesn't work well with RTL scripts (mostly arabic, though it looks kinda crappy and unnatural in hebrew too).
http://core.trac.wordpress.org/browser/trunk/wp-admin/css/wp-admin.dev.css#L2559
I sometimes use bold where an emphasis is needed, instead of italic.
#7
@
13 years ago
Yeah, just be aware that bold is -not- a vaild property for font-style. Font-style deals exclusively with the slant. For bold you need to use font-weight.
http://www.w3.org/TR/CSS21/fonts.html#font-styling
'font-style' Value: normal | italic | oblique | inherit Initial: normal Applies to: all elements Inherited: yes Percentages: N/A Media: visual Computed value: as specified
#9
@
13 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 3.4
20754.2.diff looks good.
20754.diff --
Stock had the text as a Serif font, RTL shouldn't be overriding the font-family.
Bold is a font-weight, not a font-style, and RTL shouldn't be changing that even if it were a weight.
RTL vs LTR: http://cloud.stephanis.info/1U1h0e2m1G2c27290T1y