WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 23 months ago

Last modified 23 months ago

#20754 closed defect (bug) (fixed)

Minor RTL CSS fixes for 3.4

Reported by: georgestephanis Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: RTL Keywords: has-patch commit
Focuses: Cc:

Description

Just going through and patching inconsistencies between the stock styles and the RTL styles.

Attachments (2)

20754.diff (395 bytes) - added by georgestephanis 2 years ago.
20754.2.diff (409 bytes) - added by yoavf 2 years ago.

Download all attachments as: .zip

Change History (13)

georgestephanis2 years ago

comment:1 georgestephanis2 years ago

20754.diff --

Stock had the text as a Serif font, RTL shouldn't be overriding the font-family.
Bold is a font-weight, not a font-style, and RTL shouldn't be changing that even if it were a weight.

Version 0, edited 2 years ago by georgestephanis (next)

comment:2 SergeyBiryukov2 years ago

Tahoma seems to be the best font for RTL. Some previous tickets on that topic can be found in ticket:19424:11.

comment:3 nacin2 years ago

Indeed, RTL should be Tahoma. I guess we can remove the bogus font-style, but we should blame it to figure out where and why it was added.

comment:4 georgestephanis2 years ago

Blame's got it tracked back to Azaozz @ http://core.trac.wordpress.org/changeset/17941 -- but that's likely just a overhaul of previous css, and I'm not sure how to trace it back further.

comment:6 in reply to: ↑ 5 yoavf2 years ago

Replying to SergeyBiryukov:

Added by yoavf in ticket:17324:3.2-rtl.diff.

Probably because the original style has italic, and that doesn't work well with RTL scripts (mostly arabic, though it looks kinda crappy and unnatural in hebrew too).

http://core.trac.wordpress.org/browser/trunk/wp-admin/css/wp-admin.dev.css#L2559

I sometimes use bold where an emphasis is needed, instead of italic.

comment:7 georgestephanis2 years ago

Yeah, just be aware that bold is -not- a vaild property for font-style. Font-style deals exclusively with the slant. For bold you need to use font-weight.

http://www.w3.org/TR/CSS21/fonts.html#font-styling

'font-style'
Value:  	normal | italic | oblique | inherit
Initial:  	normal
Applies to:  	all elements
Inherited:  	yes
Percentages:  	N/A
Media:  	visual
Computed value:  	as specified

comment:8 yoavf2 years ago

Oh, I knew that! Sorry about the lameness.

yoavf2 years ago

comment:9 nacin23 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.4

20754.2.diff looks good.

comment:10 nacin23 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20961]:

RTL: For the list table items count, don't italicize the text. Remove a typo that tried to convert the text to bold; normal is the preferred route here so we are not going to set a font-weight. props yoavf, georgestephanis. fixes #20754.

comment:11 nacin23 months ago

Per IRC and a conversation with yoavf, the italic isn't being used as emphasis, but as a design element. Normal text is plenty — just as long as it isn't italic.

Note: See TracTickets for help on using tickets.