Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#20763 closed defect (bug) (fixed)

Custom Background: "Restore Original Image" button displays when the original image is in the preview.

Reported by: mfields's profile mfields Owned by: nacin's profile nacin
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Customize Keywords: has-patch commit
Focuses: Cc:

Description

Here's a screenshot:
https://img.skitch.com/20120527-c5k5p7b1quqg2pfncx3b2i5emc.png

The textured image shown in the preview is the default-image specified in the call to add_theme_support( 'custom-background' ). Although the default image is currently selected as the background image, users are still given the option to restore the original image. I think that it would be best to hide the button in cases like this.

A patch is on the way!

Attachments (2)

20763.diff (563 bytes) - added by mfields 12 years ago.
20763.2.diff (1.1 KB) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (6)

@mfields
12 years ago

#1 @nacin
12 years ago

  • Keywords commit added; dev-feedback removed
  • Milestone changed from Awaiting Review to 3.4

#2 @ryan
12 years ago

Loks good.

#3 @SergeyBiryukov
12 years ago

20763.2.diff does the same for "Reset Image" button in custom-header.php.

It's a bit weird that the buttons are in different places: on Custom Background screen, it's in the middle; on Custom Header screen, it's in the bottom.

#4 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20966]:

When the current image is the default image, don't show buttons to restore to that image, for both custom headers and backgrounds. props mfields, SergeyBiryukov. fixes #20763.

Note: See TracTickets for help on using tickets.