Recommend a user updates keys/salts in maint/repair.php

[nacin]

In maint/repair.php, we tell a user they need to add WP_ALLOW_REPAIR.

Since they are already going into wp-config.php, we should also encourage them to update their unique phrases for keys and salts, assuming they do not have a complete set of 8 unique ones already.

[ryan]

Looks good.

[nacin]

In [20953]:

Do not perform nonce checks in maint/repair.php.

If the options table is damaged and the keys/salts fall back to the database,
the nonce will never validate.

fixes #20780. see #20779.

[westi]

This is an excellent idea, patch looks great.

[chriscct7]

Refreshed patch to follow core formatting standards. This is a good idea. Let's get it in.

[obenland]

In 32830:

Recommend a user updates keys/salts in maint/repair.php.

Since they are already going into wp-config.php, we should also encourage
them to update their unique phrases for keys and salts, assuming they do not
have a complete set of 8 unique ones already.

Props nacin, chriscct7.
Fixes #20779.

[nacin]

I am not sure we should harass them about missing keys.

[obenland]

I still believe this is a good change. We could adjust the wording to be even less pushy, but I think it's reasonable to recommend updating them.

[helen]

I think it's fine to prod somebody who's here about the keys, but the string is a little bit harass-y. Maybe:

While you are editing your wp-config.php file, take a moment to make sure you have all 8 keys and that they are unique. You can generate these using the WordPress.org secret key service.

[obenland]

In 33026:

Improve the tone of key/salts recommendation message.

Also adds some inline comments to make it easier to understand how it
is determined whether to show the message or not.

Props helen.
Fixes #20779.