WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#20799 closed defect (bug) (fixed)

Theme Customizer: Reduce reliance on fixed positioning and make sidebar UI flexible

Reported by: koopersmith Owned by: koopersmith
Milestone: 3.4 Priority: normal
Severity: minor Version: 3.4
Component: Customize Keywords: has-patch commit
Focuses: Cc:

Description

Since the outer shell of the customizer uses fixed positioning, we can shift fewer elements by moving to absolute positioning, which allows better use of the "right" property (as it's set to the parent element instead of the window). This can allow the width to only be declared in two locations, so the sidebar becomes easily stretchable (and adjustable via JS).

Patch attached, tested in Chrome, Safari, Firefox, Opera, IE9, and IE8.

Attachments (5)

20799.diff (3.1 KB) - added by koopersmith 4 years ago.
20799.2.diff (4.7 KB) - added by koopersmith 4 years ago.
20799.3.diff (5.5 KB) - added by koopersmith 4 years ago.
20799.4.patch (5.5 KB) - added by ocean90 4 years ago.
20799.5.diff (5.4 KB) - added by helenyhou 4 years ago.

Download all attachments as: .zip

Change History (13)

@koopersmith
4 years ago

@koopersmith
4 years ago

#1 @koopersmith
4 years ago

Latest patch adds corresponding RTL changes.

#2 @koopersmith
4 years ago

Hold the phone, helenyhou alerted me to another test case (overlays without sidebars; e.g. when opening the customizer).

@koopersmith
4 years ago

#3 @koopersmith
4 years ago

Fixed in latest patch. The overlay used in customize-loader.js is not an overlay with a sidebar, so let's not use that container class.

#4 @helenyhou
4 years ago

Latest patch looks good to me in FF and Chrome (on a limited testing environment at the moment), LTR and RTL. With patch on #20800 applied, also looks good for the install themes previewer.

@ocean90
4 years ago

#5 @ocean90
4 years ago

  • Keywords commit added

Patch looks good. I only increased the left value for .wp-full-overlay.collapsed .collapse-sidebar to prevent an overlapping of the button on the scrollbar.

Version 0, edited 4 years ago by ocean90 (next)

#6 follow-up: @ryan
4 years ago

Needs refresh.

@helenyhou
4 years ago

#7 in reply to: ↑ 6 @helenyhou
4 years ago

Replying to ryan:

Needs refresh.

20799.5.diff

#8 @ryan
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [20969]:

Theme Customizer: Reduce reliance on fixed positioning and make sidebar UI flexible. Props koopersmith, ocean90, helenyhou. fixes #20799

Note: See TracTickets for help on using tickets.