Deprecating PHP4-style constructors gracefully

[uuf6429]

The class WP_Widget in wp-includes/widget.php makes use of PHP4-style constructor for compatibility with plugins (mostly).

I propose two changes here:

• A direct call to the old constructor should trigger a deprecation notice
• The PHP4-style constructor *must* be declared after __construct() otherwise, an E_STRICT regarding constructor re-declaration is thrown.

Please find a patch attached...

[uuf6429]

diff patch

[SergeyBiryukov]

Related: ticket:18975:10

[hakre]

Related: #16768

These changes look similar to the ones I have in my patched wordpress. That fixes the E_STRICT error for me, too. I attach my changes merged with yours, I think this needs to be deprecated with the next point release (3.4.0).

Thank you for bringing that issue up, this change went a bit lost on my box.

This is a related test-case: ​http://codepad.viper-7.com/o9RHpF

[SergeyBiryukov]

Related: #24357. [24288] made the E_STRICT notice more prominent.

[michelwppi]

Cool - temporary I do the patch on my local latest 3.6 nighty built...( moving ph4 call after constructor ) - no annoying message from widget.php. (I also take opportunity to upgrade my oldest plugins using WP_Widget class) - Waiting the next 3.6 nighty built ;-)

M.

[nacin]

Not sure I see the reason for deprecating right now. Fixing the E_STRICT sounds good.

[iandunn]

20801.3.diff swaps the order of the constructors to avoid the E_STRICT notice, but doesn't deprecate the PHP4 one.

[SergeyBiryukov]

In 24296:

Move the PHP4 constructor below the PHP5 one to avoid E_STRICT message. props uuf6429, iandunn. fixes #20801.

[dd32]

#30899 was marked as a duplicate.

[TJNowell]

Of note, ​https://wiki.php.net/rfc/remove_php4_constructors PHP 7 is considering the removal of the old style constructor