WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 11 months ago

#20807 closed defect (bug) (fixed)

EXIF ISOSpeedRatings can be an array

Reported by: azaozz Owned by: azaozz
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: Upload Keywords: has-patch commit
Focuses: Cc:

Description

This trips wp_read_image_metadata(). Seems ISOSpeedRatings may include ISO Speed and ISO Latitude and is returned as array on Android devices.

Attachments (5)

20807.patch (1.5 KB) - added by azaozz 2 years ago.
20807-2.patch (2.1 KB) - added by azaozz 2 years ago.
20807-3.patch (2.1 KB) - added by azaozz 2 years ago.
20807.diff (1.4 KB) - added by nacin 2 years ago.
20807.2.diff (1.4 KB) - added by nacin 2 years ago.

Download all attachments as: .zip

Change History (14)

azaozz2 years ago

comment:1 azaozz2 years ago

20807.patch was tested on an Android phone (yes, images can be uploaded from there nicely).

azaozz2 years ago

comment:2 follow-up: azaozz2 years ago

Also hide the drag-drop area on mobile devices (this actually should be in plupload, uploader.features.dragdrop should be false for mobile).

Last edited 2 years ago by azaozz (previous) (diff)

comment:3 in reply to: ↑ 2 azaozz2 years ago

(error)

Last edited 2 years ago by azaozz (previous) (diff)

azaozz2 years ago

comment:4 azaozz2 years ago

array_shift() instead of $array['ISOSpeedRatings'][0].

comment:5 nacin2 years ago

Rather than array_shift(), we should use reset().

Looking into this patch now and testing on my Android device.

nacin2 years ago

comment:6 nacin2 years ago

  • Keywords has-patch commit added

Looks good. 20807.diff doesn't shuffle around code, and makes the array check a bit cleaner.

Tested and confirmed as working for an Android device. Suggesting commit.

comment:7 nacin2 years ago

Obviously that should be ! hasClass('mobile') -- that was me doing some testing.

nacin2 years ago

comment:8 azaozz2 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [20978]:

Fix notice in wp_read_image_metadata() when EXIF ISOSpeedRatings is array, props nacin, fixes #20807

comment:9 c3mdigital11 months ago

#16106 was marked as a duplicate.

Note: See TracTickets for help on using tickets.