custom-background $args enhancement

[frumph]

Looking to have added the rest of the arguments to pass through the $args to include the rest of the appearance -> background parameters including but not limited to position(x/y), repeat and attachment.

add_theme_support('custom-background', $args);

Example:

array(
	'default-color' => '000000', 
	'default-image' => get_stylesheet_directory_uri() . '/images/background-wolfbw.jpg',
	'repeat' => 'no-repeat',
	'position-x' => 'center',
	'attachment' => 'fixed'
);

ie. the repeat position(x/y) and attachment parameters

Main themes even child themes have looks which sometimes need to incorporate fixed or positioning that cannot be set with the current $arguments and it would benefit theme designers to allow those arguments to be passed

[obenland]

20816.diff​ lets themes define background position, repeat, and attachment for their default image in add_theme_support()

[wonderboymusic]

these are all marked 3.7-early

[obenland]

Refreshed patch, tested against latest trunk.

[nacin]

I like this but let's wait for 3.8 on this.

[lancewillett]

Can we get this into 3.8 please?

[duck_]

In 26352:

Allow customisation of theme mod defaults via custom-background theme support.

Give the power to theme authors to select defaults when registering
custom-background support.

Props obenland. Fixes #20816.

[greenshady]

Do you think we can change the background-position argument to background-position-x? This to just make sure we're consistent with naming and in case we ever add a background-position-y argument.

[nacin]

Reviewing this a bit more, I agree with adding -x to position. However, I am not sure these should be background-position, background-attachment, etc. We already have default-color and default-image. These too are defaults. So I am thinking default-position-x, default-attachment, etc. Alternatively, drop the prefix all together.

[greenshady]

I prefer the approach of using default- over background-. I don't see anything wrong with dropping it altogether either except that it wouldn't be consistent with default-image and default-color.

[nacin]

In 26594:

Rename the new custom-background arguments passed to add_theme_support().

• background-position becomes default-position-x
• background-attachment becomes default-attachment
• background-repeat becomes default-repeat

These are in line with existing default-image and default-color arguments, and also makes the position argument unambiguous and forwards compatible.

fixes #20816.