Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#20831 closed defect (bug) (fixed)

Remove unused variable from wp_update_themes()

Reported by: duck_ Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:


$update_request is never used. See [15455].

Attachments (1)

20831.diff (489 bytes) - added by duck_ 3 years ago.

Download all attachments as: .zip

Change History (3)

3 years ago

#1 @nacin
3 years ago

  • Milestone changed from Future Release to 3.5

Because we do $new_update->checked = $checked;, indeed, this is not needed.

Plugins does $new_option->checked[ $file ] = $p['Version']; but that is because $checked is not simply plugin => version, it is plugin => data. We should probably make these two functions behave exactly the same at some point, perhaps even merging them.

#2 @nacin
3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21089]:

Remove unused variable in wp_update_themes(). props duck_. fixes #20831.

Note: See TracTickets for help on using tickets.