Make WordPress Core

Opened 3 years ago

Last modified 3 weeks ago

#20842 new defect (bug)

Buttons are not on the same line when saving a post as pending (RTL)

Reported by: rasheed Owned by:
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.4
Component: I18N Keywords: ui-feedback good-first-bug
Focuses: ui Cc:


Please check attachment.

Attachments (3)

save-as-pending.gif (16.7 KB) - added by rasheed 3 years ago.
20842.ru_RU.png (13.3 KB) - added by SergeyBiryukov 3 years ago.
20842.ru_RU.2.png (12.8 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (17)

@rasheed3 years ago

comment:1 @SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.4

@SergeyBiryukov3 years ago

comment:2 @SergeyBiryukov3 years ago

  • Component changed from RTL to I18N
  • Milestone changed from 3.4 to Awaiting Review

The string is too long. Could probably remove some padding.

It's actually even worse in ru_RU (20842.ru_RU.png), and removing the padding won't help there. Should probably come up with a shorter string, but can't think of one at the moment.

Moving back from 3.4, as it's not a regression.

comment:3 follow-up: @ocean903 years ago


Is this still an issue with the new button style?

comment:4 in reply to: ↑ 3 @SergeyBiryukov3 years ago

Replying to ocean90:

Is this still an issue with the new button style?

Yep: 20842.ru_RU.2.png.

comment:5 @chriscct75 months ago

  • Focuses ui added
  • Keywords ui-feedback needs-patch added

comment:7 @wonderboymusic4 weeks ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to 4.4

comment:8 @Rynald0s3 weeks ago

  • Keywords has-patch added; needs-patch removed

Updated on #32111

comment:9 @helen3 weeks ago

What are we proposing core do here short of an overhaul, if anything?

comment:10 @SergeyBiryukov3 weeks ago

  • Keywords has-patch removed

comment:11 @SergeyBiryukov3 weeks ago

#32111 was marked as a duplicate.

comment:12 @ramonjosegn3 weeks ago

Why not put only a button with a EYE ICON?

I think is universal, and should be very small for showing.

A tooltip can show the text...

Last edited 3 weeks ago by ramonjosegn (previous) (diff)

comment:13 @juanfra3 weeks ago

Nice idea! I thought about it before. The problem I saw is that, it is the same icon used for the "visibility" state, a few pixels below.

Perhaps using the "external" button with a tooltip? https://developer.wordpress.org/resource/dashicons/#external

comment:14 @Rynald0s3 weeks ago


Regarding #32111: thanks so much for clearing things up for me. I clearly missed the user role part. However, I have double checked a clean installation (4.3) under Russian language (all user roles) and can't seem to find the "Сохранить для утверждения" string. They all show up as "Сохранить." Perhaps I am missing something (which is most likely the case).?

If I am missing something, I would agree with you on replacing the string and making it shorter. The problem however, is finding a suitable one.

Note: See TracTickets for help on using tickets.