WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#20856 closed defect (bug) (fixed)

Cannot select Custom Header or Background when searching in the Media Library

Reported by: hd-J Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: major Version: 3.4
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

Here is a missing element of the new select from Library too introduced in #19840.

Steps to reproduce:

  1. Go to Appearance > Header, or Appearance > Background, and click on "Choose image"
  2. Instead of selecting an image from the ones you see, search for a term using the search form
    • The search result does not include a link to "set as background" or "set as header"

Attachments (1)

20856.patch (793 bytes) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (6)

#1 @nacin
8 years ago

  • Milestone changed from Awaiting Review to 3.4

#2 @kovshenin
8 years ago

  • Cc kovshenin@… added

#3 @SergeyBiryukov
8 years ago

Also, hidden tabs ("From Computer" and "From URL") reappear after pressing "Search Media" button.

#4 @SergeyBiryukov
8 years ago

  • Keywords has-patch added

20856.patch preserves the context in media_upload_library_form().

There's also a suggestion to add a "context" parameter to get_upload_iframe_src() in ticket:19396:8 (#18708 and #20632 would benefit from that as well), we could probably do that in 3.5.

#5 @ryan
8 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21008]:

Preserve context when searching in the media upload form. Props SergeyBiryukov. fixes #20856

Note: See TracTickets for help on using tickets.