Opened 12 years ago
Closed 12 years ago
#20868 closed defect (bug) (fixed)
Live previewing locks the iFrame window & URL
Reported by: | jim912 | Owned by: | koopersmith |
---|---|---|---|
Milestone: | 3.4 | Priority: | normal |
Severity: | normal | Version: | 3.4 |
Component: | Customize | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
When you switch themes using the "Save and Activate" button on a live-preview window, the iFrame stays persistent unless you move away from the theme panel. This can be a problem because:
1) The URL in the address bar stays as /wp-admin/customize.php?theme=xxxxxxxxx
This means you can't see the actual URL of where you are - possibly promoting phishing.
2) You can't live preview any theme you've previously previewed.
Steps for reproduction:
- Preview Theme X
- Click "Save and Activate"
- Preview Theme Y
- Click "Save and Activate"
- Try previewing Theme X again, but you will get a blank page now.
Attachments (1)
Change History (9)
#1
@
12 years ago
- Component changed from Themes to Appearance
- Milestone changed from Awaiting Review to 3.4
#3
@
12 years ago
- Keywords needs-patch added
- Owner set to koopersmith
- Status changed from new to accepted
Sounds like something's up with pushState. I'll add it to my list.
#4
@
12 years ago
- Keywords has-patch needs-testing added; needs-patch removed
Patch should fix both of those issues. Also allows for events that have optional data.
#5
@
12 years ago
20868.diff works. Tested in Firefox 12, Chrome 19, IE 8, Opera 11.64.
Note: See
TracTickets for help on using
tickets.
Confirmed both points. The steps result in a blank screen with a spinner image. No JS errors in the console.