Removing header image does not remove header_image_data theme mod
|Reported by:||kovshenin||Owned by:||koopersmith|
|Milestone:||3.4||Priority:||highest omg bbq|
When hitting Remove Header Image in Appearance > Header, the header image mod is set to remove-header which causes get_header_image to return nothing, however, the value set for the header_image_data theme mod remains, so get_custom_header()->url will always show the last chosen header image, even if it has been removed.
This gets even nastier with flex width and height headers. When removing a header image, get_custom_header()->height will show the removed image height, and not the default theme mod height as (I) expected.
Change History (27)
- Milestone changed from Awaiting Review to 3.4
- Severity changed from normal to blocker
comment:11 @koopersmith — 3 years ago
- Keywords has-patch needs-testing added
- Owner set to koopersmith
- Status changed from new to accepted