Context Navigation

← Previous Ticket
Next Ticket →

#20879 closed defect (bug) (fixed)

Customizer: Add keyup events to sync textarea values.

Reported by:	koopersmith	Owned by:	koopersmith
Priority:	normal	Milestone:	3.4
Component:	Customize	Version:	3.4
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description

We automatically sync text inputs with their js objects using keyup, but were not syncing for textarea. We should be doing both.

Attachments (2)

20879.diff (481 bytes ) - added by koopersmith 14 years ago.
20879.2.diff (971 bytes ) - added by koopersmith 14 years ago.

Download all attachments as: .zip

Change History (8)

@koopersmith
14 years ago

Attachment 20879.diff added

#1 @koopersmith
14 years ago

Since we don't have any controls in core with textareas, here's an easy way to test the patch.

Navigate to yoursite.com/wp-admin/customize.php
Open up your browser's JS console.

Drop this code block in the console:

var textarea = jQuery('<textarea>').appendTo('#customize-theme-controls');
var element = new wp.customize.Element( textarea );
element.bind( function() {
	console.log('element changed', arguments);
});

Click inside the new textarea in the sidebar and type some text.
Click somewhere outside of the textarea.

With the patch, you should see the value changing in the console as you type. Without the patch, you'll only see a change when you click out of the textarea (triggering a change event).

#2 @ocean90
14 years ago

Looks good.

#3 @azaozz
14 years ago

Typing "Enter" in the textarea is disabled (no new line) as Enter/Return is globally caught by $('#customize-controls').on( 'keydown',... L:575 in customize-controls.dev.js.

Perhaps exclude textareas by checking e.target there?

Last edited 14 years ago by azaozz (previous) (diff)

@koopersmith
14 years ago

Attachment 20879.2.diff added

#4 @koopersmith
14 years ago

Good catch, Andrew. This patch should allow enter to be pressed in textareas.

#5 @azaozz
14 years ago

Keywords commit added

2.diff works well.

#6 @ryan
14 years ago

Resolution → fixed
Status new → closed

In [21024]:

Customizer: Add keyup events to sync textarea values. Props koopersmith. fixes #20879

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#20879 closed defect (bug) (fixed)

Customizer: Add keyup events to sync textarea values.

Description

Attachments (2)

Change History (8)

@koopersmith 14 years ago

#1 @koopersmith 14 years ago

#2 @ocean90 14 years ago

#3 @azaozz 14 years ago

@koopersmith 14 years ago

#4 @koopersmith 14 years ago

#5 @azaozz 14 years ago

#6 @ryan 14 years ago

Download in other formats:

@koopersmith
14 years ago

#1 @koopersmith
14 years ago

#2 @ocean90
14 years ago

#3 @azaozz
14 years ago

@koopersmith
14 years ago

#4 @koopersmith
14 years ago

#5 @azaozz
14 years ago

#6 @ryan
14 years ago