JS console error with comment keyboard shortcuts

[tw2113]

Keyboard shortcuts for comment moderation are throwing console errors and not doing intended results due to it.

The console error:

TypeError: e.all[o] is undefined

mydomain.com/wp-admin/load-scripts.php?c=1&load=admin-bar,hoverIntent,common,jquery-color,wp-ajax-response,wp-lists,quicktags,jquery-query,admin-comments,jquery-hotkeys,jquery-table-hotkeys,word-count,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-ui-button,jquery-ui-position,jquery-ui-dialog,wpdialogs,wplink,wpdialogs-popup&ver=3.4-RC2-21026
Line 21

[ocean90]

Please define ​SCRIPT_DEBUG and check your console again.

[tw2113]

With Script Debug turned on. Sorry about that part.

TypeError: that.all[element] is undefined
​http://mydomain.com/wp-includes/js/jquery/jquery.hotkeys.dev.js?ver=0.0.2m
Line 84

[SergeyBiryukov]

Hmm. Not sure what's going on, but I see the same error in all releases back to 2.7 when the shortcuts were introduced. Tested in Firefox 12 by pressing j/k on the Comments screen.

[SergeyBiryukov]

Works fine (including current trunk) in Chrome 19 and Opera 11.64.

Doesn't work in IE 8 (same error as in Firefox).

[SergeyBiryukov]

FWIW, works in Firefox 3.6.25.

[tw2113]

I'll add in that it wasn't working in Firefox 14 and didn't change for 15. I run their Aurora channel and it updated today. Still the same errors.

[SergeyBiryukov]

Updating jQuery Hotkeys plugin to 0.8+ (​https://github.com/tzuryby/jquery.hotkeys) fixes the issue.

[ocean90]

Related/duplicate: #19489

[azaozz]

Replying to SergeyBiryukov:

Updating jQuery Hotkeys plugin to 0.8+ (​https://github.com/tzuryby/jquery.hotkeys) fixes the issue.

Yes, but also requires a lot of changes to table-hotkeys.dev.js as the plugin is completely different (for the better).

If we want this in 3.4 perhaps we can fix the old plugin, seems there is quite a bit of outdated code there but disabling some of the unnecessary things makes it work again.

[SergeyBiryukov]

20885.2.patch​ seems to fix the issue in the old plugin.

[azaozz]

Replying to SergeyBiryukov:

Ah, you beat me to it :)

Yes, that was the problem, seems to work in all browsers now.

[SergeyBiryukov]

Some more testing without the patches: worked in Firefox 9, stopped working in Firefox 10.

[azaozz]

Tested in all supported browsers, works.

[ryan]

20885.2.patch?

[SergeyBiryukov]

Same as 20885-3.patch, with better formatting

[azaozz]

Replying to ryan:

20885.2.patch?

Yes, 2.patch fixes the problem, 3.patch also removes some unneeded checks that are handled by jQuery now and 4.patch fixes the formatting. All three patches work with 4.patch being the best to go in.

[ryan]

In [21035]:

Fix comment hotkeys for FF and IE. Props azaozz, SergeyBiryukov. fixes #20885