Opened 13 years ago
Closed 13 years ago
#20885 closed defect (bug) (fixed)
JS console error with comment keyboard shortcuts
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Comments | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Keyboard shortcuts for comment moderation are throwing console errors and not doing intended results due to it.
The console error:
TypeError: e.all[o] is undefined
mydomain.com/wp-admin/load-scripts.php?c=1&load=admin-bar,hoverIntent,common,jquery-color,wp-ajax-response,wp-lists,quicktags,jquery-query,admin-comments,jquery-hotkeys,jquery-table-hotkeys,word-count,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-ui-button,jquery-ui-position,jquery-ui-dialog,wpdialogs,wplink,wpdialogs-popup&ver=3.4-RC2-21026
Line 21
Attachments (4)
Change History (21)
#2
@
13 years ago
With Script Debug turned on. Sorry about that part.
TypeError: that.all[element] is undefined
http://mydomain.com/wp-includes/js/jquery/jquery.hotkeys.dev.js?ver=0.0.2m
Line 84
#3
@
13 years ago
Hmm. Not sure what's going on, but I see the same error in all releases back to 2.7 when the shortcuts were introduced. Tested in Firefox 12 by pressing j/k on the Comments screen.
#4
@
13 years ago
Works fine (including current trunk) in Chrome 19 and Opera 11.64.
Doesn't work in IE 8 (same error as in Firefox).
#6
@
13 years ago
I'll add in that it wasn't working in Firefox 14 and didn't change for 15. I run their Aurora channel and it updated today. Still the same errors.
#7
follow-up:
↓ 10
@
13 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to Future Release
Updating jQuery Hotkeys plugin to 0.8+ (https://github.com/tzuryby/jquery.hotkeys) fixes the issue.
#10
in reply to:
↑ 7
@
13 years ago
Replying to SergeyBiryukov:
Updating jQuery Hotkeys plugin to 0.8+ (https://github.com/tzuryby/jquery.hotkeys) fixes the issue.
Yes, but also requires a lot of changes to table-hotkeys.dev.js as the plugin is completely different (for the better).
If we want this in 3.4 perhaps we can fix the old plugin, seems there is quite a bit of outdated code there but disabling some of the unnecessary things makes it work again.
#12
in reply to:
↑ 11
@
13 years ago
Replying to SergeyBiryukov:
Ah, you beat me to it :)
Yes, that was the problem, seems to work in all browsers now.
#13
@
13 years ago
Some more testing without the patches: worked in Firefox 9, stopped working in Firefox 10.
#14
@
13 years ago
- Keywords commit added; needs-testing removed
- Milestone changed from Future Release to 3.4
Tested in all supported browsers, works.
Please define SCRIPT_DEBUG and check your console again.