Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#20887 closed defect (bug) (worksforme)

Widget titles - some characters cropped

Reported by: pavelevap's profile pavelevap Owned by:
Milestone: Priority: low
Severity: minor Version: 3.2
Component: UI Keywords: has-patch
Focuses: Cc:

Description

Some characters are cropped in widget titles in administration, please see attached screenshot (using latest trunk, Chrome).

1) Current situation (cropped "j" characters").

2) Removing line-height: 1; shows all characters, but the whole title is moved a little down.

Attachments (6)

Widget_titles.jpg (7.7 KB) - added by pavelevap 12 years ago.
20887.patch (489 bytes) - added by SergeyBiryukov 12 years ago.
20887.after.png (6.1 KB) - added by SergeyBiryukov 12 years ago.
20887.tag-cloud.png (6.1 KB) - added by SergeyBiryukov 12 years ago.
20887.2.patch (477 bytes) - added by SergeyBiryukov 12 years ago.
Refreshed after [21592]
20887.3.patch (528 bytes) - added by lessbloat 12 years ago.
Added note about odd line height in CSS.

Download all attachments as: .zip

Change History (19)

#1 @alexvorn2
12 years ago

maybe the problem is in the translated text?

#2 @pavelevap
12 years ago

I do not think so, tested also in original english version, you can see this problem for example at "Categories" widget.

#3 @alexvorn2
12 years ago

maybe to remove the overflow property instead of line-height...
not only j character is cropped but p, g also...

#4 @alexvorn2
12 years ago

  • Keywords needs-patch added
  • Severity changed from normal to major

#5 @nacin
12 years ago

Is this a problem in 3.3, or just 3.4?

#6 @pavelevap
12 years ago

I noticed this problem also in 3.2.1.

#7 @alexvorn2
12 years ago

@nacin Version 3.3.2, 3.4 too

#8 @ocean90
12 years ago

  • Version changed from 3.4 to 3.2

#9 @azaozz
12 years ago

  • Component changed from Widgets to UI
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Severity changed from major to minor

This is dependent on the font and the browser. Generally line-height: 1; shouldn't hide the top and bottom bits of letters only make the lines "touch" vertically. However some browsers don't render this properly.

Thinking there are few more places where this may be happening.

(BTW, perhaps we need "CSS" component for things like this?)

#10 @SergeyBiryukov
12 years ago

  • Keywords has-patch added; needs-patch removed

#11 @SergeyBiryukov
12 years ago

  • Milestone changed from Future Release to 3.5

To reproduce, move Tag Cloud widget to the Inactive Widgets area (20887.tag-cloud.png).

20887.patch fixes that as well. Tested in Firefox 13, Chrome 19, IE 8, Opera 11.64.

@SergeyBiryukov
12 years ago

Refreshed after [21592]

@lessbloat
12 years ago

Added note about odd line height in CSS.

#12 @lessbloat
12 years ago

While I couldn't replicate the issue without the patch, after applying the patch, everything looks fine.

#13 @SergeyBiryukov
12 years ago

  • Milestone 3.5 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Tested again in Firefox 15, Chrome 22, IE 7, IE 8, Opera 12.

Could not reproduce Widget_titles.jpg or 20887.tag-cloud.png in current trunk.

Note: See TracTickets for help on using tickets.