WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#20890 closed defect (bug) (worksforme)

Standardize line endings of wp-config-sample.php and wp-fullscreen.css

Reported by: xknown Owned by:
Milestone: Priority: normal
Severity: trivial Version:
Component: General Keywords:
Focuses: Cc:

Description

Two core files seem to have invalid line endings (\r).

~/data/wp$ ack -l "\r"
wp-includes/js/tinymce/plugins/wpfullscreen/css/wp-fullscreen.css
wp-config-sample.php

~/data/wp$ cat -vT wp-config-sample.php | head
<?php^M
/**^M
 * The base configurations of the WordPress.^M
 *^M
 * This file has the following configurations: MySQL settings, Table Prefix,^M
 * Secret Keys, WordPress Language, and ABSPATH. You can find more information^M
 * by visiting {@link http://codex.wordpress.org/Editing_wp-config.php Editing^M
 * wp-config.php} Codex page. You can get the MySQL settings from your web host.^M
 *^M
 * This file is used by the wp-config.php creation script during the^M

Change History (5)

#1 @xknown
8 years ago

  • Summary changed from Standardize line endings to Standardize line endings of wp-config-sample.php and wp-fullscreen.css

Add a more descriptive summary.

#2 @nacin
8 years ago

wp-fullscreen.css definitely should be LF line endings (perhaps svn:eol-style: native is missing on some new files) but wp-config-sample.php is deliberately CRLF.

#3 @xknown
8 years ago

More files (other than wp-config-sample.php) that probably need svn:eol-style:native.

/data/wp$ find . -type f | grep -v .svn | xargs svn propget svn:eol-style | grep CRLF
wp-includes/images/crystal/license.txt - CRLF
wp-includes/js/scriptaculous/MIT-LICENSE - CRLF
license.txt - CRLF
wp-config-sample.php - CRLF

I didn't think about that some Windows users use notepad to edit their wp-config.php file

#4 @dd32
8 years ago

Any user-readable files should be CRLF for maximum compatibility, ie. wp-config-sample.php and any license files. Not all license files are CRLF though i don't think, The only change here should be to make all the license files consistent.

#5 @nacin
7 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.