WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#20892 closed defect (bug) (fixed)

Customizer: Separate message url from preview url in customizer JS Previewer and PreviewFrame objects

Reported by: koopersmith's profile koopersmith Owned by: koopersmith's profile koopersmith
Milestone: 3.4 Priority: high
Severity: blocker Version: 3.4
Component: Customize Keywords: commit
Focuses: Cc:

Description

Currently, the message url and preview url are cobbled together inside the previewer — this worked when we did not have robust PreviewFrame objects. However, now that we have first class preview objects, we need to properly distinguish between the url the messages are sent over (the control url, because we're using dynamically created iframes), and the URL of the preview request.

Without this, cross-domain requests are failing based on origin mismatches, which is bad. Patch coming soon.

Attachments (1)

20892.diff​ (5.3 KB) - added by koopersmith 11 years ago.

Download all attachments as: .zip

Change History (3)

@koopersmith
11 years ago

#1 @ryan
11 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.4

Looks good.

#2 @koopersmith
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [21033]:

Theme Customizer: Separate message url from preview url in customizer JS Previewer and PreviewFrame objects. fixes #20892.

Note: See TracTickets for help on using tickets.