WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 weeks ago

#20899 reviewing defect (bug)

is_home() should be able to be true when is_feed()

Reported by: nacin Owned by: johnbillion
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Query Keywords: has-patch needs-testing needs-unit-tests
Focuses: Cc:

Description

is_feed() is a special query flag that can be combined with other query flags — for example, is_author() && is_feed() for /author/admin/feed/.

But it can't be combined with is_home(), because is_home() is the fallback that is only set to true when a lot of other things are true — including is_feed(). This appears to be incorrect — is_home() should still be able to be true despite is_feed().

I tracked this down to [1449]. What kind of breakage could occur with this?

Attachments (1)

20899.diff (826 bytes) - added by stevenkword 11 months ago.

Download all attachments as: .zip

Change History (13)

#1 @johnbillion
4 years ago

  • Cc johnbillion added

#2 @batmoo
4 years ago

  • Cc batmoo@… added

#3 @ocean90
3 years ago

#22031 was marked as a duplicate.

#5 @wonderboymusic
2 years ago

  • Keywords needs-patch reporter-feedback added; has-patch removed

How this make you feel now - still needed?

#6 @stevenkword
11 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

Patch 20899.diff removes the is_feed check when assigning the value for the is_home query argument.

@stevenkword
11 months ago

#8 @stevenkword
6 months ago

Anyone have an argument against this?

#9 @johnbillion
5 months ago

  • Owner set to johnbillion
  • Status changed from new to reviewing

#10 @stevenkword
7 weeks ago

  • Milestone changed from Future Release to 4.5

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


3 weeks ago

#12 @johnbillion
3 weeks ago

  • Keywords needs-unit-tests added; reporter-feedback removed
Note: See TracTickets for help on using tickets.