Opened 11 years ago
Last modified 4 years ago
#20902 reviewing defect (bug)
redirect_canonical() on using permalink: Not all $_GET being redirected
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.4 |
Component: | Canonical | Keywords: | has-patch needs-testing early |
Focuses: | Cc: |
Description
Using permalink, I suppose that all query_var entered manually on URL or using $_GET will be redirected to proper permalink. Apparently not all being redirected at all. AFAIC:
- /?post_format=image : should be redirected to /type/image/
- /?pagename=blog : should be redirected to /blog/
- /?author_name=admin : should be redirected to /author/admin/
Unfortunately, they are not.
It can be done by filtering redirect_canonical() but it will be better if it's being done by default as we can see that /?category_name=cat will be redirected to /category/cat/
Attachments (3)
Change History (13)
#3
@
11 years ago
- Keywords has-patch needs-testing dev-feedback added; needs-patch removed
20920.diff fixes all three scenarios, mainly by adding logic to canonical.php
. As for the post format canonical redirects, the current tax query redirects seems to handle tags, categories and custom taxonomy well, but the extra post_type
query argument added in _post_format_request
prevented it from doing so.
I feel weird that categories, tags and custom post types won't append the post_type
argument, even if added to other object types with register_taxonomy_for_object_type
, so I don't understand the reason why it's there for post formats, since post formats is a taxonomy, just like everything else, except that it has a custom admin interface. Would like feedback on this from Andrew and/or Mark, see [17249].
#4
@
9 years ago
@davejesch, @jdangl, and I tested this at the ocwp meetup on 4.1-alpha-30299 and the patch didn't apply. We updated the patch and applied it. As @kovshenin said, it fixes all three scenarios.
This ticket was mentioned in Slack in #core by brandondove. View the logs.
9 years ago
This ticket was mentioned in Slack in #core by brandondove. View the logs.
9 years ago
#7
@
9 years ago
- Keywords needs-unit-tests added; dev-feedback removed
The patch still looks like it's the right direction to go in, although we should also add some unit tests for these new redirections, covering both has-posts and no-posts for authors.
Confirmed all 3 issues are still current, There are existing tickets for 2 & 3 I believe.