WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 13 months ago

#20907 new enhancement

About screen text assumes user has update privileges

Reported by: johnbillion Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.3
Component: Help/About Keywords: needs-patch dev-feedback
Focuses: administration Cc:

Description

From the 'About' screen in WordPress:

Thank you for updating to the latest version!

But I didn't! I am just a lowly editor. My administrator probably updated the site for me.

We shouldn't show this sentence if the user doesn't have the update_core capability.

Attachments (1)

20907.diff (727 bytes) - added by leewillis77 4 years ago.
Rather than hide the sentence, can we just make it generic? The attached changes it to "Your site has been updated to WordPress %s! You might not notice a thing, and we’re okay with that." Note also the change from a hardcoded 3.7 to %s to pull through the version number automatically.

Download all attachments as: .zip

Change History (8)

#1 @johnbillion
5 years ago

  • Component changed from Administration to Help/About
  • Keywords needs-patch added

@leewillis77
4 years ago

Rather than hide the sentence, can we just make it generic? The attached changes it to "Your site has been updated to WordPress %s! You might not notice a thing, and we’re okay with that." Note also the change from a hardcoded 3.7 to %s to pull through the version number automatically.

#2 @leewillis77
4 years ago

  • Keywords has-patch added; needs-patch removed

#3 @Hanni
4 years ago

  • Cc h@… added

#4 @kpdesign
4 years ago

  • Keywords needs-patch dev-feedback added; has-patch removed

@johnbillion: Thanks for the report. I'm sorry it took so long to get a response.

@leewillis77: Thanks for the patch. Looks like the hard-coded version number issue was fixed in 26737.

I can verify that this is still an issue in trunk. "Thank you for updating to WordPress 3.9, the most beautiful WordPress yet." displays for all users, not just users with the update_core capability.

There are 3 possible solutions:

  • Create a generic version of the message that would be displayed to all users.
  • Only show the message to users who have the update_core capability, and hide it from all other users.
  • Use the same approach as the update banner, and show one message to users with the update_core capability, and another message to all other users.

#5 @chriscct7
2 years ago

  • Focuses administration added
  • Keywords needs-testing added

Issue in question needs to be re-verified.

#6 @voldemortensen
13 months ago

  • Keywords needs-testing removed

Just confirmed on 4.6 that issue still exists.

#7 @voldemortensen
13 months ago

After taking 2 seconds longer to think about this, part of the problem is that this string changes with every release when the about page is redone. Since the about page is manually designed every release, this needs to be thought about every time. There's not a one time fix for this.

Note: See TracTickets for help on using tickets.