Opened 12 years ago
Closed 12 years ago
#20916 closed defect (bug) (fixed)
Network Enable theme after installation doesn't work
Reported by: | duck_ | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.4 | Priority: | normal |
Severity: | normal | Version: | 3.4 |
Component: | Themes | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Network enabling a theme after installation, see #18468 and [18569], doesn't work in 3.4. This is because the redirect was switched back to use the referer in [20151].
Network Enabling child themes just doesn't work, and never did as far as I can tell, because of the use of $template instead of $stylesheet. Related: #20914.
Attachments (2)
Change History (9)
#2
follow-up:
↓ 4
@
12 years ago
You could network enable child themes just fine, just not from the upgrader. And the upgrader only started supporting child themes in 3.4.
With regards to the impetus to switch back to referer in [20151] — I'm sure I noticed it improved the UX a bit (returning to the same filter page, or same paginated page, etc.), but clearly, the status quo in [18569] and 20916.diff at least doesn't break, for the moment.
#4
in reply to:
↑ 2
@
12 years ago
Replying to nacin:
You could network enable child themes just fine, just not from the upgrader
Indeed. I should have made it clearer that the context for everything I was talking about was from the post-installation screen.
#6
@
12 years ago
20916.2.diff provides the better experience while not breaking the uploader. Tested.
Note that the act of network enabling the theme does actually happen (for non-child themes), but you're redirected back to the install page which attempts to reinstall the theme and gives an error message because it's already installed.
For child themes it doesn't work and you're redirected to a nonce failure.