Users with PHP 5.2.4 or lower will receive notice "wrong parameter count for debug_backtrace()"

[swekitsune]

If you try to update Wordpress to 3.4 on a server using PHP 5.2.4 or lower, the user will receive the notice "wrong parameter count for debug_backtrace()". In the function "wp_debug_backtrace_summary" we can see that the usage of debug_backtrace looks like this:

$trace  = debug_backtrace( false );

In PHP 5.2.4 or lower, debug_backtrace() doesn't accept any parameters – however, laters versions do.

For the time being, it is easily fixed (just remove "false") but a permanent fix should be sought for.

[swekitsune]

Changed the title to be more descriptive.

[nacin]

This means you are running SAVEQUERIES in production, or are generating queries with errors, which are both bad.

As a "permanent" fix we could A) conditionally call debug_backtrace() with either one or no arguments, and B) if we call it with no arguments, we'll need to ignore the object ourselves.

[nacin]

I think this actually generates an E_WARNING for PHP core functions, rather than E_NOTICE, so assigning to 3.4.1.

[kurtpayne]

Use php-version specific options for debug_backtrace()

[kurtpayne]

Replying to nacin:

I think this actually generates an E_WARNING for PHP core functions, rather than E_NOTICE, so assigning to 3.4.1.

Confirmed E_WARNING. Submitted 20953.patch​ for the following:

php < 5.2.5 = debug_backtrace
php 5.2.5 to 5.3.5 = debug_backtrace(false)
php 5.3.6+ = debug_backtrace(0)

false vs. 0 is semantics, but 0 emphasizes that it's a bitmask field.

[nacin]

In [21113]:

Don't call debug_backtrace() with an argument for PHP 5.2.4, which is currently the lowest version we support. props swekitsune, kurtpayne. fixes #20953.

[nacin]

In [21119]:

Don't call debug_backtrace() with an argument for PHP 5.2.4, which is currently the lowest version we support. props swekitsune, kurtpayne. fixes #20953 for 3.4.