Opened 12 years ago
Closed 12 years ago
#20957 closed defect (bug) (fixed)
Replace wpspin_dark with a better image
Reported by: | alexvorn2 | Owned by: | azaozz |
---|---|---|---|
Milestone: | 3.5 | Priority: | normal |
Severity: | normal | Version: | 3.4 |
Component: | UI | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
http://wpimpact.com/wp-content/uploads/2012/06/Untitled-7.png
wpspin_dark animation icon look ugly, to replace or to improve, like in Firefox but grey color: http://wpimpact.com/wp-content/uploads/2012/06/Untitled-9.png
Attachments (2)
Change History (10)
@
12 years ago
As far as I can tell wpspin_dark.gif is only used in one spot in widgets.php. Maybe we should just switch that one instance to wpspin_light.gif.
#2
@
12 years ago
- Component changed from Widgets to UI
- Keywords has-patch added; needs-patch 2nd-opinion needs-ui removed
- Milestone changed from Awaiting Review to 3.5
The contrast is a little lower, but it is so, so much better.
#3
@
12 years ago
Related ticket:21019#comment:68
#4
@
12 years ago
As far as I see this spinner only shows when rearranging widgets in the same sidebar (dragging them up or down). Frankly, not sure if it's needed at all.
#6
@
12 years ago
Also, it looks like it's a left over from long ago, when the sidebars had dark headers (2.6 or 2.7). It's shown so seldom that seems nobody noticed it for years :)
#7
@
12 years ago
- Keywords commit added
Let's go ahead and replace it with the lighter version, and delete that awful dark one. 20957.2.diff
Holy wow that thing is ugly.
wpspin_light.gif
is significantly better, but a closer look also shows some funkiness going on at the pixel level. A quick replace of that instance in the widget area title, which is the only one I found in core, with the light version looks fine, though less contrast. Then we could delete the dark one outright. If somebody wants to make a better dark version, make sure that it matches the style of the light one or make both.