WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#20961 closed defect (bug) (fixed)

Network Themes “View version detail“ link needs the right overlay

Reported by: ocean90's profile ocean90 Owned by: nacin's profile nacin
Milestone: 3.4.1 Priority: normal
Severity: normal Version: 3.4
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

Current is too small, since it's still use Thickbox.

Screenshot: ​http://cl.ly/HN9D

Attachments (2)

20961.wp33.png​ (14.9 KB) - added by SergeyBiryukov 12 years ago.
20961.patch​ (842 bytes) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (9)

@SergeyBiryukov
12 years ago

#1 follow-up: @SergeyBiryukov
12 years ago

In 3.1 to 3.3, "View version details" in network admin looks broken too (20961.wp33.png​).

The API no longer returns screenshot_url field.

#2 in reply to: ↑ 1 @nacin
12 years ago

Replying to SergeyBiryukov:

The API no longer returns screenshot_url field.

Fixed on the WP.org side.

@SergeyBiryukov
12 years ago

#3 @SergeyBiryukov
12 years ago

  • Keywords has-patch added; needs-patch removed

20961.patch​ makes the link consistent with the one on the regular Manage Themes screen (given that #20960 is fixed).

#4 @nacin
12 years ago

Looks good.

#5 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21110]:

Fix 'View version details' link for network/themes.php. In 3.5 these should stop pointing to WP.org. props SergeyBiryukov, fixes #20961 for trunk.

#6 @nacin
12 years ago

In [21111]:

Fix 'View version details' link for network/themes.php. In 3.5 these should stop pointing to WP.org. props SergeyBiryukov, fixes #20961 for 3.4.

#7 @rzen
11 years ago

#17387 was marked as a duplicate.

Note: See TracTickets for help on using tickets.