WordPress.org

Make WordPress Core

Opened 23 months ago

Closed 22 months ago

Last modified 5 weeks ago

#20961 closed defect (bug) (fixed)

Network Themes “View version detail“ link needs the right overlay

Reported by: ocean90 Owned by: nacin
Milestone: 3.4.1 Priority: normal
Severity: normal Version: 3.4
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

Current is too small, since it's still use Thickbox.

Screenshot: http://cl.ly/HN9D

Attachments (2)

20961.wp33.png (14.9 KB) - added by SergeyBiryukov 22 months ago.
20961.patch (842 bytes) - added by SergeyBiryukov 22 months ago.

Download all attachments as: .zip

Change History (9)

SergeyBiryukov22 months ago

comment:1 follow-up: SergeyBiryukov22 months ago

In 3.1 to 3.3, "View version details" in network admin looks broken too (20961.wp33.png).

The API no longer returns screenshot_url field.

comment:2 in reply to: ↑ 1 nacin22 months ago

Replying to SergeyBiryukov:

The API no longer returns screenshot_url field.

Fixed on the WP.org side.

SergeyBiryukov22 months ago

comment:3 SergeyBiryukov22 months ago

  • Keywords has-patch added; needs-patch removed

20961.patch makes the link consistent with the one on the regular Manage Themes screen (given that #20960 is fixed).

comment:4 nacin22 months ago

Looks good.

comment:5 nacin22 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21110]:

Fix 'View version details' link for network/themes.php. In 3.5 these should stop pointing to WP.org. props SergeyBiryukov, fixes #20961 for trunk.

comment:6 nacin22 months ago

In [21111]:

Fix 'View version details' link for network/themes.php. In 3.5 these should stop pointing to WP.org. props SergeyBiryukov, fixes #20961 for 3.4.

comment:7 rzen5 weeks ago

#17387 was marked as a duplicate.

Note: See TracTickets for help on using tickets.