Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#21012 closed defect (bug) (fixed)

Dashboard plugin stats widget messing up plugin title

Reported by: georgestephanis's profile georgestephanis Owned by: nacin's profile nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4
Component: General Keywords: has-patch commit
Focuses: Cc:


When a user's name has double-quotes in it, like Otto ( ), the line in the code

if ( preg_match( '/"(.*)"/s', $item->get_title(), $matches ) )

escapes the title from

Samuel "Otto" Wood on "Facebook"


Otto" Wood on "Facebook

Let's actually make it sniff for the on before the double-quote to avoid this.

Attachments (1)

21012.diff (593 bytes) - added by georgestephanis 12 years ago.

Download all attachments as: .zip

Change History (7)

#1 @georgestephanis
12 years ago

For the record, what this bug results in on the dashboard screen is:

#2 @SergeyBiryukov
12 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.5

#3 @Otto42
12 years ago

For the time being I've removed the quotes in my name, but seriously, this is stupid.

#4 @nacin
12 years ago

To avoid any potential conflicts, let's just change the RSS feeds on to remove the name, then remove those lines of code, leaving the forward-compatible lines.

#5 @nacin
12 years ago

Deploying the change to

#6 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21160]: no longer returns this old structure. The title of the item is the plugin name in full. fixes #21012.

Note: See TracTickets for help on using tickets.