Months dropdown should not show if only posts are 'auto-draft' status

[CoenJacobs]

The months dropdown at the top of edit.php should only show if there are actually posts in the list.

Right now, if you click 'Add new' an auto draft post will be saved. Leave the post edit screen without saving the post (so no draft will be created) and go back to the edit.php screen. There is no post in the list, but the month drop down will be shown because the auto draft is counted.

[CoenJacobs]

Filters out the posts with 'auto-draft' as status in counting query

[MikeHansenMe]

filters trash status as well.

[MikeHansenMe]

While testing this patch I realized that it was also showing dates of posts that had been deleted or 'trash' status. I updated the file to prevent both.

[MikeHansenMe]

Just realized my patch was removing dates from the trash link above the posts. I updated to allow dates for trash posts for trash status only.

[CoenJacobs]

After testing your patch, I found out that it needs to check for the $_GET variable to be set to prevent notices. Patched that, done some testing with it. Looks good to me now.

[MikeHansenMe]

Looks good

[SergeyBiryukov]

#22033 was marked as a duplicate.

[CoenJacobs]

Revised patch, tested against current trunk

[CoenJacobs]

Tested this again against current trunk and made a small adjustment (no use checking for $_GET['post_status'] twice, it's there or it's not). This needs a second set of eyes to test.

[seanchayes]

I emulated the issue with both Posts and Pages. Without the 21015.5 patch applied I saw that the additional month was in the dropdown even though no associated post/page showed in the All Posts/Pages list.

I applied the 21015.5 patch and repeated the exercise and found that only the month(s) with relevant / actively created content showed in the dropdown.

I also added a register_post_type call for "Listings" in my _s theme to generate a custom post type. I observed the same behavior as above in the all "Listings" view edit.php?post_type=listing before and after the patch was applied.

[MikeHansenMe]

Refreshed for 4.3

[swissspidy]

Latest patch still applies and works. Can we get this into 4.4?

[jorbin]

Wouldn't it also make sense to hide the other two dropdowns as well? You can't do any bulk actions to non existant posts and you can't filter by categories if there are no posts.

[swissspidy]

Replying to jorbin:

Wouldn't it also make sense to hide the other two dropdowns as well? You can't do any bulk actions to non existant posts and you can't filter by categories if there are no posts.

There's #21856 for the category dropdown and I just created #33824 for the bulk actions dropdown

[wonderboymusic]

In 34076:

List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination.

Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.

Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824, #21015, #21856.

[wonderboymusic]

In 34077:

After [34076], fix the logic for post_status in months dropdown.

See #21015.