WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#21046 closed defect (bug) (wontfix)

Dashboard "Right Now" widget hook should be right_now_end, not rightnow_end

Reported by: schreifels Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.4
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

In /wp-admin/includes/dashboard.php , the following callback is used:

do_action( 'rightnow_end' );

However, the documentation and logic (for consistency with right_now_content_table_end, right_now_table_end, etc) would tell us that the hook should actually be called right_now_end.

Attachments (1)

21046.patch (479 bytes) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (5)

#1 @Ipstenu
6 years ago

  • Keywords needs-patch added

#2 @SergeyBiryukov
6 years ago

  • Component changed from Widgets to Administration
  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.7

21046.patch adds the new action and keeps the current one for backwards compatibility.

Version 0, edited 6 years ago by SergeyBiryukov (next)

#3 @SergeyBiryukov
6 years ago

  • Keywords commit added

#4 @nacin
6 years ago

  • Milestone 3.7 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I don't think this matters much. Inline documentation for hooks will handle nagging issues like whether hooks are discoverable. Also, if we're going to possibly do a redesigned Right Now at some point in the next few releases, this is little more than cruft.

Note: See TracTickets for help on using tickets.