Backwards logic in get_attachment_template

[jfarthing84]

It seems to me that the logic in get_attachment_template is backwards. Aren't templates supposed to go from specific to general? All others do, except attachments. Let's fix that.

[jfarthing84]

Reverse order of attachment template hierarchy.

[jfarthing84]

Also just noticed that with the most specific template, the intended result isn't even used. For instance, a JPEG image would be image_jpeg.php. However, get_query_template uses a regular expression that removes the underscore, thus changing the template it looks for to imagejpeg.php. I suggest that the underscore be changed to a dash, thus matching the WordPress file naming convention and avoiding this problem.

[jfarthing84]

Change underscore to dash in most specific scenario of attachment template.

[jfarthing84]

Related #15337.

[nacin]

This is a duplicate of #15337. Your insight in comment:1 here could be very helpful there. ("Also just noticed that with the most specific template, the intended result isn't even used.") Can we move the conversation over there?