WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 21 months ago

#21060 closed defect (bug) (fixed)

Duplicate time format suggestions if locale's time format is the same as default time format

Reported by: waclawjacek Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: minor Version: 3.4
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

The default time format is set to “H:i” in the Polish translation, but this results in duplicate “H:i” entries on the settings screen (see: attachment). Happens in version 3.4 and earlier.

Andrew Nacin's suggestion on "WP Polyglots":

A simple array_unique() should be enough there, on both $time_formats and $date_formats.

Attachments (2)

zrzutekranuz20120623122.png (5.6 KB) - added by waclawjacek 2 years ago.
21060.patch (881 bytes) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (5)

SergeyBiryukov2 years ago

comment:1 SergeyBiryukov2 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.5

Thanks, I had it on my list as well.

comment:2 ryan21 months ago

  • Keywords commit added

comment:3 nacin21 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [22299]:

Don't show the same time or date format twice on the General Settings page. This can occur if a translated format is the same as an existing default format. fixes #21060.

Note: See TracTickets for help on using tickets.