Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#21065 closed enhancement (fixed)

Themes: update allowed theme tags to add flexible-header

Reported by: lancewillett Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch commit
Focuses: Cc:

Description (last modified by lancewillett)

Update the "wporg_theme_feature_list" list of available theme tags to include 'flexible-header' — a feature term to denote themes that support the new WP 3.4 flexible custom header header feature.

Patch also adds new term 'flexible-header' term to Twenty Ten and Twenty Eleven stylesheets.

(Previously: #17359)

Attachments (2)

21065.patch (3.4 KB) - added by lancewillett 3 years ago.
21065.2.patch (3.3 KB) - added by lancewillett 3 years ago.

Download all attachments as: .zip

Change History (18)

@lancewillett3 years ago

comment:1 @kobenland3 years ago

  • Cc obenland@… added

comment:2 @kovshenin3 years ago

  • Cc kovshenin@… added

comment:3 @lancewillett3 years ago

Cross-posted to http://make.wordpress.org/themes/2012/07/18/id-love-your-thoughts-on-adding-two-new/ to get input from Theme Review Team on adding these two new tags.

We've been using them both for a while now on WP.com, and I think it makes sense for everyone to start using them, and for plugins like Theme Check to recognize as valid—and the Extend uploader script, of course.

comment:4 @emiluzelac3 years ago

  • Cc emil@… added

comment:5 @senlin3 years ago

  • Cc info@… added

comment:6 @pauldewouters3 years ago

  • Cc pauldewouters added

comment:7 @mercime3 years ago

  • Cc mercijavier@… added

comment:8 @ramiy3 years ago

Maybe related: #21256

comment:9 @lancewillett3 years ago

After discussion on Make Themes, I think a better approach is to rename "Widths" terms to "Layout" and change the three allowed values to "Fixed, Fluid, Resonsive".

comment:10 @lancewillett3 years ago

  • Description modified (diff)
  • Summary changed from Themes: update allowed theme tags to add flexible-header and responsive-width to Themes: update allowed theme tags to add flexible-header

Split out new term changes for layout/width to #21442 so we can get flexible-header in now.

@lancewillett3 years ago

comment:11 @SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.5

comment:12 @sabreuse3 years ago

  • Cc sabreuse@… added

comment:13 @lancewillett3 years ago

In [21533]:

Twenty Twelve: add flexible-header tag back into style.css, in anticipation of it being a core-allowed tag, see #21065.

Remove responsive-width since it's not decided yet, see #21065.

comment:14 @lancewillett3 years ago

  • Keywords commit added

Ready for commit, please.

comment:15 @nacin3 years ago

  • Keywords i18n-change removed

comment:16 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21604]:

Add new 'flexible-header' tag for themes. Add it to Twenty Ten and Twenty Eleven. [21533] added it for Twenty Twelve.

props lancewillett. fixes #21065.

Note: See TracTickets for help on using tickets.