WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 8 months ago

Last modified 8 months ago

#21073 closed enhancement (wontfix)

Main functions file (/wp-includes/functions.php) could use a coding standards cleanup

Reported by: evansolomon Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

This file is very inconsistent in its coding standards, and as a result is difficult to read.

I had to find a couple things in here recently; after some frustration in reading the different styles I decided to take a pass at refreshing it.

Attachments (1)

21073.diff (63.1 KB) - added by evansolomon 22 months ago.

Download all attachments as: .zip

Change History (4)

evansolomon22 months ago

comment:1 c3mdigital8 months ago

  • Keywords has-patch removed
  • Resolution set to maybelater
  • Status changed from new to closed

As much as I'm for coding standards I will refer to: http://make.wordpress.org/core/2011/03/23/code-refactoring/

Refactoring patches require unit tests, performance benchmarks, proper justification and clear rationale.

comment:2 SergeyBiryukov8 months ago

  • Milestone Awaiting Review deleted
  • Resolution changed from maybelater to wontfix

Formatting cleanup tickets are generally discouraged. Coding style fixes should be a result of more substantial changes.

comment:3 SergeyBiryukov8 months ago

  • Keywords has-patch added
Note: See TracTickets for help on using tickets.