Merge safe_mode change in PHPMailer from upstream

[nacin]

See #20970.

Merge in the activity from ​http://code.google.com/a/apache-extras.org/p/phpmailer/issues/detail?id=68 into 3.5, if it is not the same as [21128].

[cnorris23]

Patched according to revision 95 ​http://code.google.com/a/apache-extras.org/p/phpmailer/source/detail?spec=svn95&r=95

[nacin]

Doesn't work. It calls mail_passthru() as if it is a function, rather than a method. Reporting this (and some code duplication) upstream.

[nacin]

​http://code.google.com/a/apache-extras.org/p/phpmailer/issues/detail?id=72

[bpetty]

As long as we don't have an imminent release here, this should wait for the official PHPMailer 5.2.2 release with these changes anyway (even if it didn't have problems).

[bpetty]

21074-phpmailer-5.2.2-beta1.patch is a direct copy of class-phpmailer.php and class-smtp.php from the official PHPMailer 5.2.2-beta1 release.

This should be used for testing while we still have some time to wait on official 5.2.2 since this is planned to be applied for 3.5.

[bpetty]

Updated patch with PHPMailer 5.2.2-beta2.

[SergeyBiryukov]

Related: #21738

[bpetty]

Working on update for minor bug in latest patch....

[bpetty]

Fixed WP-specific filename changes from upstream.

[nacin]

Are we sure that PHPMailer 5.2.2 will actually be out by, say, the end of October? I don't have a lot of confidence at the moment when it comes to the stability of this project's pre-release versions (see ​the report and 3rd comment here), nor, given the glacially slow life cycle of that project, do I know if we can count on a final release before next year.

[bpetty]

Given the current releases of beta1 on Jul 13th, beta2 on Aug 17th, and that the changelog already lists 5.2.2 next in the changelog (see ​changelog.txt), I'm fairly confident that this will hit in the next few weeks.

You did mention that we can still just revert back to current 5.2.1 (and our custom fixes to it) before RC if it's not released, even if there are no problems found with 5.2.2-beta2. Just keep this ticket open as a reminder on the 3.5 milestone just in case.

Also note that beta2 contains the fix for #11988, not just the upsteam safe_mode fix btw.

[bpetty]

Refreshed patch based on PHPMailer 5.2.2-rc1 released on September 28th.

[nacin]

We are running latest + a patch. Punting and can be brought back for 3.6 assuming 5.2.2 is released by then.

[bpetty]

Refreshed patch based on PHPMailer 5.2.2-rc2 release.

[bpetty]

Refreshed patch based on PHPMailer 5.2.2-rc2 release.

[bpetty]

Ignore that first one, some odd whitespace characters slipped into the filename somehow.

[bpetty]

Refreshed patch based on PHPMailer 5.2.2 release.

[bpetty]

Refreshed patch based on PHPMailer 5.2.4 release.

[nacin]

In 23522:

Update to PHPMailer 5.2.4. props bpetty. fixes #21074.