Opened 13 years ago
Closed 13 years ago
#21115 closed defect (bug) (fixed)
Remove ancient wp-settings.php global unsetting code
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Unit Tests | Keywords: | |
Focuses: | Cc: |
Description
We have this:
// Ensure these global variables do not exist so they do not interfere with WordPress. unset( $wp_filter, $cache_lastcommentmodified );
It used to include more variables, but they were removed when a few of us took an axe to wp-settings.php back in 3.0.
I suggest we remove both. $cache_lastcommentmodified can easily become a static variable within that function (I mean, we're dealing with pre-1.5 code here) and a lot of things would be broken if people overrode WordPress globals prior to startup, not just $wp_filter.
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
Side effect: Removing the unset() for $wp_filter can allow the test suite to add some filters prior to startup, rather than a more explicit re-organization proposed in #20731.