Remove _http_build_query compatibility function

[kurtpayne]

WordPress requires PHP 5.2.4+ which includes http_build_query(). http_build_query() is already used in update.php and class-http.php. We should remove the compatibility function and be more consistent.

[kurtpayne]

Deprecate _http_build_query

[dd32]

Although this function started out life as a compatibility function.. It's got some non-php-core functionality in it, which is why it's been used directly rather than through a compat wrapper.

Specifically, the PHP version doesn't support the final parameter, $urlencode, which core uses to produce url's usable for Location headers (IIRC) amongst other things.

[kurtpayne]

Replying to dd32:

Specifically, the PHP version doesn't support the final parameter, $urlencode, which core uses to produce url's usable for Location headers (IIRC) amongst other things.

In PHP 5.4, there's an $enc_type parameter. Probably best to leave this function in until WordPress requires php 5.4.

[dd32]

I agree with leaving it alone for now.