Opened 14 years ago
Closed 14 years ago
#21138 closed defect (bug) (fixed)
Comments rewrite contains bogus rule
| Reported by: | nacin | Owned by: | nacin |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Rewrite Rules | Version: | |
| Severity: | normal | Keywords: | has-patch commit 3.6-early |
| Cc: | Focuses: |
Description (last modified by )
[comments/feed/(feed|rdf|rss|rss2|atom)/?$] =>
index.php?&feed=$matches[1]&withcomments=1
[comments/(feed|rdf|rss|rss2|atom)/?$] =>
index.php?&feed=$matches[1]&withcomments=1
[comments/page/?([0-9]{1,})/?$] =>
index.php?&paged=$matches[1]
That last rule doesn't make any sense. We should call generate_rewrite_rules() with $paged = false here.
Attachments (1)
Change History (7)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
I found this when porting over the test_query.php unit tests:
// 'comments/page/?([0-9]{1,})/?$' => 'index.php?&paged=$matches[1]', function test_comments_page() { $this->http('/comments/page/2/'); $this->assertQueryTrue('is_home', 'is_paged'); }