Make WordPress Core

Opened 6 years ago

Last modified 5 years ago

#21138 closed defect (bug)

Comments rewrite contains bogus rule — at Version 1

Reported by: nacin Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Rewrite Rules Keywords: has-patch commit 3.6-early
Focuses: Cc:

Description (last modified by nacin)

[comments/feed/(feed|rdf|rss|rss2|atom)/?$] =>

[comments/(feed|rdf|rss|rss2|atom)/?$] =>

[comments/page/?([0-9]{1,})/?$] =>

That last rule doesn't make any sense. We should call generate_rewrite_rules() with $paged = false here.

Change History (1)

#1 @nacin
6 years ago

  • Description modified (diff)

I found this when porting over the test_query.php unit tests:

// 'comments/page/?([0-9]{1,})/?$' => 'index.php?&paged=$matches[1]',
function test_comments_page() {
       $this->assertQueryTrue('is_home', 'is_paged');
Note: See TracTickets for help on using tickets.