Opened 12 years ago
Closed 12 years ago
#21161 closed enhancement (invalid)
Use protocol relative gravatar URLs
Reported by: | charliesome | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch |
Focuses: | Cc: |
Description
This patch changes the get_avatar()
function in wp-includes/pluggable.php
to use protocol relative URLs instead of attempting to detect whether the blog is running over SSL or not.
The //gravatar.com/...
links will use HTTP if the page is loaded over HTTP, or HTTPS is the page is loaded over HTTPS. These URLs are widely supported - they'll even work on IE6.
This is preferable as the current code will not work if Apache (or whichever server Wordpress is running on) is not the same server as the one doing SSL.
Attachments (1)
Change History (4)
#2
@
12 years ago
Not sure about this. Note the use of distributed subdomain selection based on the email address (which this patch removes). This improves performance on pages with many avatars (as browsers typically only load 2 resources from a given domain simultaneously).
#3
@
12 years ago
- Milestone 3.5 deleted
- Resolution set to invalid
- Status changed from new to closed
-1 on this for two reasons:
- This is not how the gravatar.com service is meant to be used. As johnbillion points out, note the distributed subdomain selection. Second, note secure.gravatar.com rather than gravatar.com. That is gravatar.com's preference.
+1. I don't get why we don't use protocol agnostic URLs accross the board.