![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 14 years ago
Closed 14 years ago
#21186 closed defect (bug) (fixed)
WP_Rewrite::mod_rewrite_rules() should use site_url()
| Reported by: | JustinSainton | Owned by: | nacin |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Rewrite Rules | Version: | 3.4.1 |
| Severity: | normal | Keywords: | has-patch dev-feedback |
| Cc: | Focuses: |
Description
I could be off here, but I'm thinking site_url() should be used here in place of get_option( 'siteurl' ). The potential issues are naturally inferred, and slightly further down in the function, home_url() is used.
Let me know if I'm missing something here.
Attachments (1)
Change History (4)
Note:
See TracTickets
for help on using tickets.
It's been using get_option()/get_setting() forever. There doesn't seem to be a reason is hasn't changed to site_url(). mod_rewrite_rules() is scheme agnostic so the patch should be fine.